[node-patches] Change in ovirt-node[master]: init: Add a dummy interface for libvirtd

[danken at redhat.com]

Dan Kenigsberg has posted comments on this change.

Change subject: init: Add a dummy interface for libvirtd
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/39995/1/scripts/ovirt-init-functions.sh.in
File scripts/ovirt-init-functions.sh.in:

Line 1452: 
Line 1453:         # Small hack to fix https://bugzilla.redhat.com/show_bug.cgi?id=805313
Line 1454:         service network restart 2>/dev/null
Line 1455: 
Line 1456:         # Another nasty hack to fix bug FIXME
Please mention the BZ number 1209401, for future reference
Line 1457:         # FIXME discuss if we can't use an 127.0.0.x address instead, to prevent collisions with public address ranges
Line 1458:         ip link add dummyuglyhack type dummy
Line 1459:         ip address add 99.99.99.99 dev dummyuglyhack
Line 1460: 


Line 1453:         # Small hack to fix https://bugzilla.redhat.com/show_bug.cgi?id=805313
Line 1454:         service network restart 2>/dev/null
Line 1455: 
Line 1456:         # Another nasty hack to fix bug FIXME
Line 1457:         # FIXME discuss if we can't use an 127.0.0.x address instead, to prevent collisions with public address ranges
indeed - a local address would be less ugly. please try if it makes libvirt happy.
Line 1458:         ip link add dummyuglyhack type dummy
Line 1459:         ip address add 99.99.99.99 dev dummyuglyhack
Line 1460: 
Line 1461: 


-- 
To view, visit https://gerrit.ovirt.org/39995
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idcc569856ffd46f252a0db63f8736ca6ec9f46f5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes