[node-patches] Change in ovirt-node[master]: rhn_page: Add validators for username and profile

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: rhn_page: Add validators for username and profile
......................................................................


Patch Set 3: Code-Review-1 Verified+1

(1 comment)

Basically good, just a nitpick

https://gerrit.ovirt.org/#/c/39765/3/src/ovirt/node/valid.py
File src/ovirt/node/valid.py:

Line 321:             FQDNLength()(value)
Line 322:         return is_valid
Line 323: 
Line 324: 
Line 325: class IsAscii(Validator):
Please rename the class from IsAscii to Ascii.

I agree that IsAscii might make more sense, but for now we never used the Is… scheme in this module.
Line 326:     """ Checks if the param is ascii or not.
Line 327: 
Line 328:     >>> IsAscii().validate('rhn.user.123')
Line 329:     True


-- 
To view, visit https://gerrit.ovirt.org/39765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34f80719034f28b252a889230753dd79d288b279
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes