[node-patches] Change in ovirt-node[master]: [DRAFT] Initial pass at cleaning up rhn_page

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: [DRAFT] Initial pass at cleaning up rhn_page
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/40242/3/src/ovirt/node/setup/rhn/rhn_page.py
File src/ovirt/node/setup/rhn/rhn_page.py:

Line 247:                                                                txs, self)
Line 248:                 progress_dialog.run()
Line 249:         return self.ui_content()
Line 250: 
Line 251:     def _get_rhn_config(self):
All of this moved code should directly go to a new class, dedicated to the classic RHN, then we can create new classes for Satellite and SAM
Line 252:         # Could be RHN classic/satellite or subscription, so check both
Line 253:         conf_files = ["/etc/sysconfig/rhn/up2date",
Line 254:                       "/etc/rhsm/rhsm.conf"]
Line 255: 


-- 
To view, visit https://gerrit.ovirt.org/40242
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide8dec4c91464a3c4a54a19890b3806b318f308a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes