[node-patches] Change in ovirt-node[master]: upgrade: add step to execute checkisomd5

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: upgrade: add step to execute checkisomd5
......................................................................


Patch Set 2: Code-Review+1 -Verified

(1 comment)

https://gerrit.ovirt.org/#/c/40375/2/scripts/ovirt-node-upgrade.py
File scripts/ovirt-node-upgrade.py:

Line 319:         os.execl(reboot, reboot)
Line 320: 
Line 321:     def _checkisomd5(self, isofile):
Line 322:         self._logger.info("Checking iso md5")
Line 323:         self._system("checkisomd5", isofile)
> This call should check the return code and raise an Exception when checkiso
I've missread the patch. self._system is doing those checks
Line 324: 
Line 325:     def _reboot(self, delay):
Line 326:         self._logger.info("Scheduling Reboot")
Line 327:         self._simpleDaemon(


-- 
To view, visit https://gerrit.ovirt.org/40375
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I970614eb865c7c55cd24c2b264e1fa28b02568e9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes