[node-patches] Change in ovirt-node[master]: Providing correct path to fingerprint keyes

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: Providing correct path to fingerprint keyes
......................................................................


Patch Set 2:

(1 comment)

Nice to see this verified.

Let's just do the last change, then we can merge it.

https://gerrit.ovirt.org/#/c/44323/2/scripts/ovirt-init-functions.sh.in
File scripts/ovirt-init-functions.sh.in:

Line 1523:                 runcon -t unconfined_t "$handler" 2>&1
Line 1524:             done
Line 1525:         fi
Line 1526: 
Line 1527:         ovirt_store_config $(ls /etc/ssh/ssh_host*_key*)
I agree with Douglas, let's make a loop and then we are good - The issue is that our implementations of store_config and alike are not consistent. (WRT single file vs list of files as arguments)
Line 1528: 
Line 1529:         # FIXME is this still needed?
Line 1530:         if is_standalone; then
Line 1531:             return 0


-- 
To view, visit https://gerrit.ovirt.org/44323
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8466ccabc143e41b1507d5020664a0a05e5c784
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes