[node-patches] Change in ovirt-node[master]: network: write new hostname into /etc/hostname

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: network: write new hostname into /etc/hostname
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/44455/3/src/ovirt/node/config/network.py
File src/ovirt/node/config/network.py:

Line 230:         utils.process.check_call(["hostnamectl", "set-hostname",
Line 231:                                   new_hostname])
Line 232: 
Line 233:         # FIXME:
Line 234:         # hostnamectl --static is not writing into /etc/hostname.
So, what files does hostnamectl use?

And why do we need /etc/hostname?

If hostnamectl is writing the chostname elsewhere, then we can just use thats ource, instead of keeping /etc/hostname
Line 235:         # Because of that, the new hostname won't persist across
Line 236:         # reboot in case user change it via TUI.
Line 237:         # Restarting systemd-hostnamed doesn't help either.
Line 238:         with open('/etc/hostname', 'w+') as f:


-- 
To view, visit https://gerrit.ovirt.org/44455
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bbb7b96f98a70915190846eb7c9d3b22e0af3a1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes