[node-patches] Change in ovirt-node[master]: network: write new hostname into /etc/hostname

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: network: write new hostname into /etc/hostname
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/44455/6/src/ovirt/node/config/network.py
File src/ovirt/node/config/network.py:

Line 236:         # reboot in case user change it via TUI.
Line 237:         # Restarting systemd-hostnamed doesn't help either.
Line 238:         hostname_file = fs.File("/etc/hostname")
Line 239:         hostname_file.write(contents=new_hostname, mode="w+")
Line 240:         fs.Config().persist("/etc/hostname")
Not sure why you added this after we agreed that the caller should take care of this.
Line 241: 
Line 242:     return socket.gethostname()
Line 243: 
Line 244: 


-- 
To view, visit https://gerrit.ovirt.org/44455
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bbb7b96f98a70915190846eb7c9d3b22e0af3a1
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes