[node-patches] Change in ovirt-node[master]: Log about non-zero exit codes from lvm displays, try partials

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: Log about non-zero exit codes from lvm displays, try partials
......................................................................


Patch Set 1: Code-Review-2

After long thought and a bit discussion, a conclusion.

Let's be more careful. Currently the patch will basically ignore partial VGs - the problem I see is that there might be something wrong with the environment - and thus the installation should not be performed, butrather the env should be cleaned.

The fix for the associated bug should rather be to detect that there are some partial volume groups and then raise a descriptive error, with the hint to ensure that zonig etc is correct.

The current situation is that some non-meaningful error is raised if partial VGs are seen, the change is to make this error more clear.

-- 
To view, visit https://gerrit.ovirt.org/47090
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8ff2930ca97731af512d0dfede441dc7aeea785
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No