[node-patches] Change in ovirt-node[master]: utils/network: NIC() set config.bridge

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: utils/network: NIC() set config.bridge
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/49051/2/src/ovirt/node/utils/network.py
File src/ovirt/node/utils/network.py:

Line 224: 
Line 225:         self.config = NicConfig(ifname)
Line 226:         self.typ = self._udevinfo.devtype or self._sysfsinfo.systype
Line 227: 
Line 228:         if self.typ == "bridge":
This fix is at the wrong place.

The NIC class should not be aware of anything related to bridges.

It should be fixed in the BridgedNIC class.
Line 229:             self.config.bridge = self.ifname
Line 230: 
Line 231:     def exists(self):
Line 232:         """If this NIC currently exists in the system


-- 
To view, visit https://gerrit.ovirt.org/49051
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia680a3ed97b3352dfe07f8653010df20a53f3683
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes