[node-patches] Change in ovirt-node[master]: We should cat the old snmp_conf, not the snmp_conf dir

fabiand at redhat.com fabiand at redhat.com
Tue Dec 22 12:01:13 UTC 2015


Fabian Deutsch has submitted this change and it was merged.

Change subject: We should cat the old snmp_conf, not the snmp_conf dir
......................................................................


We should cat the old snmp_conf, not the snmp_conf dir

Missed during the code review from the last patch -- don't try to
cat a directory. cat the conf instead.

Rename the variables so they make more sense and this won't get
confused again if anyone touches it in the future

Change-Id: I2662ca403f99de9c5c9f9603e27b2407d44c431b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1261424
Signed-off-by: Ryan Barry <rbarry at redhat.com>
---
M src/ovirt/node/setup/snmp/snmp_model.py
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Fabian Deutsch: Looks good to me, approved; Passed CI tests
  Ryan Barry: Verified



-- 
To view, visit https://gerrit.ovirt.org/50634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2662ca403f99de9c5c9f9603e27b2407d44c431b
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the node-patches mailing list