[node-patches] Change in ovirt-node[master]: subscription-manager can return 0 when not registered...

fabiand at redhat.com fabiand at redhat.com
Tue Dec 22 12:03:30 UTC 2015


Fabian Deutsch has submitted this change and it was merged.

Change subject: subscription-manager can return 0 when not registered...
......................................................................


subscription-manager can return 0 when not registered...

Though I tested this earlier, it appears that relying on
"subcription-manager status" returning a non-zero exit code when
there was a problem registering is not reliable.

It still happens on some situations, though, so check the output,
and check again when there's an exception (just to make sure we
give users the right output)

Change-Id: Ifc8ef7dcf35634b5f67a45a44bc4f416d34ecd39
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1280215
Signed-off-by: Ryan Barry <rbarry at redhat.com>
---
M src/ovirt/node/setup/rhn/rhn_page.py
1 file changed, 10 insertions(+), 8 deletions(-)

Approvals:
  Fabian Deutsch: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/50542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc8ef7dcf35634b5f67a45a44bc4f416d34ecd39
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the node-patches mailing list