[node-patches] Change in ovirt-node[ovirt-3.6]: Only set free space to 0 if fill_data is actually set

fabiand at redhat.com fabiand at redhat.com
Tue Dec 22 15:00:22 UTC 2015


Fabian Deutsch has uploaded a new change for review.

Change subject: Only set free space to 0 if fill_data is actually set
......................................................................

Only set free space to 0 if fill_data is actually set

Instead of checking whether fill_data exists (which will also be
true if it's been unchecked), check whether it's true.

Change-Id: I0d22232cb8c353527fdd57ca01b5c34955c74de2
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1153472
Signed-off-by: Ryan Barry <rbarry at redhat.com>
---
M src/ovirt/node/installer/core/confirmation_page.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/13/50913/1

diff --git a/src/ovirt/node/installer/core/confirmation_page.py b/src/ovirt/node/installer/core/confirmation_page.py
index 25f67e1..daff2c1 100644
--- a/src/ovirt/node/installer/core/confirmation_page.py
+++ b/src/ovirt/node/installer/core/confirmation_page.py
@@ -127,12 +127,12 @@
          re.match(r'storage.*?size$', k) and not _model[k].endswith(" MB")]
 
         if "storage.fill_data" in _model:
-            _model["storage.free_space"] = "0"
+            if _model["storage.fill_data"]:
+                _model["storage.free_space"] = "0"
             del _model["storage.fill_data"]
         _model["installation.devices"].sort()
 
         self._model = _model
-        self.logger.debug("SET %s" % _model)
 
     def _storage_tagged(self, dev):
         found = False


-- 
To view, visit https://gerrit.ovirt.org/50913
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d22232cb8c353527fdd57ca01b5c34955c74de2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>



More information about the node-patches mailing list