[node-patches] Change in ovirt-node[master]: ovirt-node-upgrade: set ret statement correctly

fabiand at redhat.com fabiand at redhat.com
Tue Feb 3 13:14:40 UTC 2015


Fabian Deutsch has submitted this change and it was merged.

Change subject: ovirt-node-upgrade: set ret statement correctly
......................................................................


ovirt-node-upgrade: set ret statement correctly

Move the ret statement equals 0 (non error) when upgrade action is
executed sucessfully instead of call it on the finally clause which
might hide real issues on tools outside ovirt-node-upgrade.

Change-Id: Ia18a7d3b27c01001d47f8a91c59dc33d218f0c57
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1182089
Signed-off-by: Douglas Schilling Landgraf <dougsland at redhat.com>
---
M scripts/ovirt-node-upgrade.py
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Fabian Deutsch: Verified; Looks good to me, approved
  Douglas Schilling Landgraf: Verified
  Anatoly Litovsky: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/36921
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia18a7d3b27c01001d47f8a91c59dc33d218f0c57
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the node-patches mailing list