[node-patches] Change in ovirt-node[master]: confirmation_page: Add validation for unknown device

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: confirmation_page: Add validation for unknown device
......................................................................


Patch Set 1:

(1 comment)

See my inline comment

http://gerrit.ovirt.org/#/c/36105/1/src/ovirt/node/installer/core/confirmation_page.py
File src/ovirt/node/installer/core/confirmation_page.py:

Line 146:             device = all_devices[dev]
Line 147:             txt = self._plugin._header.format(bus=device.bus, name=device.name,
Line 148:                                               size="%sGB" % device.size)
Line 149:         else:
Line 150:             txt = self._plugin._header.format(bus="", name=dev, size="")
Why not just use txt= ""
Line 151: 
Line 152:         self.text(txt)
Line 153: 
Line 154:     def value(self, value=None):


-- 
To view, visit http://gerrit.ovirt.org/36105
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If08541192fef9e263436a0c5768d2f9a95ee9b01
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes