[node-patches] Change in ovirt-node[master]: hooks: Add on-boot hook validate-owner-ssh-keys

fabiand at redhat.com fabiand at redhat.com
Mon Feb 23 14:50:46 UTC 2015


Fabian Deutsch has posted comments on this change.

Change subject: hooks: Add on-boot hook validate-owner-ssh-keys
......................................................................


Patch Set 9:

(1 comment)

Just one nitpick

http://gerrit.ovirt.org/#/c/37993/9/hooks/on-boot/03-validate-owner-ssh-keys
File hooks/on-boot/03-validate-owner-ssh-keys:

Line 55: pass
Please add some kind of logging here. There can be exceptions related to some other part.


-- 
To view, visit http://gerrit.ovirt.org/37993
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaafad60288d87a41470dae581e6a2c6bc77369cd
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes



More information about the node-patches mailing list