[node-patches] Change in ovirt-node[master]: Add configure_* methods to ovirt.node.config.defaults

[rbarry at redhat.com]

Ryan Barry has uploaded a new change for review.

Change subject: Add configure_* methods to ovirt.node.config.defaults
......................................................................

Add configure_* methods to ovirt.node.config.defaults

For everything we may reasonably want to configure from dbus which
doesn't already have the methods, add them.

Figuring out how to message type signatures (for arrays, bools,
etc) and what type signatures are optional (in case of Python's
default arguments, which dbus doesn't handle nicely without
needing to specify "signature='...'" when calling it) will be
handled later.

Just doing legwork.

Change-Id: Icbd9543d0ec97ba724b9a6cf675036944bc4c24a
Signed-off-by: Ryan Barry <rbarry at redhat.com>
---
M src/ovirt/node/config/defaults.py
1 file changed, 45 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/20/38220/1

diff --git a/src/ovirt/node/config/defaults.py b/src/ovirt/node/config/defaults.py
index b5314ee..6268741 100755
--- a/src/ovirt/node/config/defaults.py
+++ b/src/ovirt/node/config/defaults.py
@@ -798,6 +798,9 @@
         return {"OVIRT_DNS": ",".join(servers) or None
                 }
 
+    def configure_nameservers(self, servers):
+        self.update(servers)
+
     def retrieve(self):
         """We mangle the original vale a bit for py convenience
         """
@@ -897,6 +900,9 @@
         return {"OVIRT_NTP": ",".join(servers) or None
                 }
 
+    def configure_timeservers(self, servers):
+        self.update(servers)
+
     def retrieve(self):
         cfg = dict(NodeConfigFileSection.retrieve(self))
         cfg.update({"servers": cfg["servers"].split(",") if cfg["servers"]
@@ -966,6 +972,9 @@
         (valid.Empty(or_none=True) | valid.FQDNOrIPAddress())(server)
         valid.Port()(port)
 
+    def configure_syslog(self, server, port=None):
+        self.update(server, port)
+
     def transaction(self):
         return self.__legacy_transaction()
 
@@ -1003,6 +1012,9 @@
     def update(self, server, port):
         valid.FQDNOrIPAddress()(server)
         valid.Port()(port)
+
+    def configure_collectd(self, server, port):
+        self.update(server, port)
 
     def transaction(self):
         return self.__legacy_transaction()
@@ -1333,6 +1345,9 @@
         (valid.Empty(or_none=True) | valid.FQDNOrIPAddress())(target_host)
         (valid.Empty(or_none=True) | valid.Port())(target_port)
 
+    def configure_initiator_name(self, name):
+        self.update(name, None, None, None)
+
     def transaction(self):
         cfg = dict(self.retrieve())
         initiator_name = cfg["name"]
@@ -1365,6 +1380,9 @@
     def update(self, enabled):
         (valid.Boolean() | valid.Empty(or_none=True))(enabled)
         return {"OVIRT_SCSI_DH_ALUA": "true" if enabled else None}
+
+    def configure_dh_alua(self, enabled):
+        self.update(enabled)
 
     def retrieve(self):
         cfg = dict(NodeConfigFileSection.retrieve(self))
@@ -1407,6 +1425,9 @@
     def update(self, server, port):
         (valid.Empty(or_none=True) | valid.FQDNOrIPAddress())(server)
         valid.Port()(port)
+
+    def configure_netconsole(self, server, port):
+        self.update(server, port)
 
     def transaction(self):
         def _clear_config():
@@ -1479,6 +1500,12 @@
                 "OVIRT_LOGROTATE_INTERVAL": "daily" if interval is None
                 else interval}
 
+    def configure_logrotate_interval(self, interval):
+        self.update(None, interval)
+
+    def configure_logrotate_max_size(self, max_size):
+        self.update(max_size, None)
+
     def transaction(self):
         cfg = dict(self.retrieve())
         max_size = cfg["max_size"] or 1024
@@ -1527,6 +1554,9 @@
         # FIXME Some validation that layout is in the list of available layouts
         pass
 
+    def configure_layout(self, layout):
+        self.update(layout)
+
     def transaction(self):
         cfg = dict(self.retrieve())
         layout = cfg["layout"]
@@ -1564,6 +1594,9 @@
         (valid.Empty() | valid.FQDN())(domain)
         return {"OVIRT_NFSV4_DOMAIN": domain or None
                 }
+
+    def configure_domain(self, domain):
+        self.update(domain)
 
     def transaction(self):
         cfg = dict(self.retrieve())
@@ -1617,6 +1650,18 @@
                 "OVIRT_DISABLE_AES_NI": "true" if disable_aesni else None
                 }
 
+    def configure_aesni(self, enabled):
+        self.update(None, None, None, enabled)
+
+    def configure_pwauth(self, enabled):
+        self.update(enabled, None, None, None)
+
+    def configure_port(self, port):
+        self.update(None, port, None, None)
+
+    def configure_bytes(self, num_bytes):
+        self.update(None, None, num_bytes, None)
+
     def retrieve(self):
         cfg = dict(NodeConfigFileSection.retrieve(self))
         cfg.update({"pwauth": True if cfg["pwauth"] == "yes" else False,


-- 
To view, visit https://gerrit.ovirt.org/38220
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icbd9543d0ec97ba724b9a6cf675036944bc4c24a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>