[node-patches] Change in ovirt-node[master]: ovirtfunctions: Remove all partporbe/kpartx calls

[fabiand at redhat.com]

Fabian Deutsch has uploaded a new change for review.

Change subject: ovirtfunctions: Remove all partporbe/kpartx calls
......................................................................

ovirtfunctions: Remove all partporbe/kpartx calls

Previously we kept some kaprtx and partprobe calls around, but those
calls do more harm than good, thus we remove these calls.
The reason why they were introduced was probably to workaround partition
discovery problems in earlier days.

Change-Id: Ia7a77c35ca0315a0e981e7d277b6ad711c69b872
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1178937
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M src/ovirtnode/storage.py
1 file changed, 1 insertion(+), 9 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/94/36594/1

diff --git a/src/ovirtnode/storage.py b/src/ovirtnode/storage.py
index a81cdff..0ed9500 100644
--- a/src/ovirtnode/storage.py
+++ b/src/ovirtnode/storage.py
@@ -248,14 +248,6 @@
         logger.debug("Rereading pt")
         _functions.system("sync")
         if "dev/mapper" in drive:
-            # kpartx -a -p p "$drive"
-            # XXX fails with spaces in device names (TBI)
-            # ioctl(3, DM_TABLE_LOAD, 0x966980) = -1 EINVAL (Invalid argument)
-            # create/reload failed on 0QEMU   QEMU HARDDISK  drive-scsi0-0-0p1
-            _functions.system("kpartx -a '%s'" % drive)
-            _functions.system("partprobe")
-            # partprobe fails on cdrom:
-            # Error: Invalid partition table - recursive partition on /dev/sr0.
             _functions.system("service multipathd reload")
             _functions.system("multipath -r &>/dev/null")
             # wait for device to exit
@@ -880,7 +872,7 @@
                          str(self.RootBackup_end) + "M\"")
             logger.debug(parted_cmd)
             _functions.system(parted_cmd)
-            _functions.system("sync ; udevadm settle ; partprobe")
+            _functions.system("sync ; udevadm settle")
             parted_cmd = ("parted \"" + self.ROOTDRIVE +
                          "\" -s \"set 2 boot on\"")
             logger.debug(parted_cmd)


-- 
To view, visit http://gerrit.ovirt.org/36594
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7a77c35ca0315a0e981e7d277b6ad711c69b872
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at redhat.com>