[node-patches] Change in ovirt-node[master]: Adding iso boot editing capability

[tlitovsk at redhat.com]

Anatoly Litovsky has posted comments on this change.

Change subject: Adding iso boot editing capability
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/36490/3/tools/edit-node
File tools/edit-node:

Line 1811:                 print "Editing Complete"
Line 1812:                 editor._configure_bootloader(
Line 1813:                     editor._LiveImageCreatorBase__isodir)
Line 1814:                 # make sure all bootloader images present even in old images
Line 1815:                 # just by copyin efi boot , it didnt boot mac anyway before
> If we do not need the macboot image (on which I agree) why do you copy it? 
an older image with out it cant be repacked unless i add it. 
new image creator insist that it must be present
Line 1816:                 if not os.path.isfile(editor._LiveImageCreatorBase__isodir+"/isolinux/macboot.img"):
Line 1817:                     shutil.copy(editor._LiveImageCreatorBase__isodir+"/isolinux/efiboot.img",
Line 1818:                                 editor._LiveImageCreatorBase__isodir+"/isolinux/macboot.img")
Line 1819:                 rebuild_iso_symlinks(editor._LiveImageCreatorBase__isodir)


-- 
To view, visit http://gerrit.ovirt.org/36490
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b0b93b75ad37ab1a0ccf890739bd692a5f835fe
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes