[node-patches] Change in ovirt-node[master]: Local kdump changes for EL7

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: Local kdump changes for EL7
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/36312/1/src/ovirt/node/config/defaults.py
File src/ovirt/node/config/defaults.py:

Line 1121:                         "path": "/core"}
Line 1122: 
Line 1123:                 # kdumpctl on EL7 doesn't like it if the path doesn't
Line 1124:                 # exist
Line 1125:                 if not os.path.isdir(os.path.join("/data", vals["path"])):
This will not work as expected: os.path.join will discard all previous parts, if some part contains a leading slash:

    os.path.join("/a", "/b", "/c") == "/c"

it only works when no trailing slashes are used.
See also: https://docs.python.org/2/library/os.path.html#os.path.join
Line 1126:                         os.makedirs(os.path.join("/data", vals["path"]))
Line 1127: 
Line 1128:                 _set_values(vals)
Line 1129: 


-- 
To view, visit http://gerrit.ovirt.org/36312
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0279e23957f2297b6f544f0171c205897ef8e0b2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes