[node-patches] Change in ovirt-node[master]: ovirt-node-upgrade: set ret statement correctly

[tlitovsk at redhat.com]

Anatoly Litovsky has posted comments on this change.

Change subject: ovirt-node-upgrade: set ret statement correctly
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/36921/1/scripts/ovirt-node-upgrade.py
File scripts/ovirt-node-upgrade.py:

Line 370:             except Exception as e:
Line 371:                 self._logger.exception('Error: Upgrade Failed: %s', e)
Line 372:                 self._run_hooks("rollback")
Line 373:                 self._logger.info("Upgrade Failed, Rollback Completed")
Line 374:                 ret = 1
I would put this ret = 1 before the try 
just in case more exceptions added
Line 375:             finally:
Line 376:                 self._cleanup()
Line 377:             sys.exit(ret)
Line 378: 


-- 
To view, visit http://gerrit.ovirt.org/36921
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia18a7d3b27c01001d47f8a91c59dc33d218f0c57
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes