[node-patches] Change in ovirt-node[master]: Don't glob the initramfs, use explicit kernel versions

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: Don't glob the initramfs, use explicit kernel versions
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/36987/1/recipe/common-nochroot.ks
File recipe/common-nochroot.ks:

Line 2: %include version.ks
Line 3: 
Line 4: echo "Copying the initrd out..."
Line 5: cp $INSTALL_ROOT/boot/initramfs-\
Line 6: $(rpm -q --qf "%{VERSION}-%{RELEASE}.%{ARCH}" kernel).img \
I wonder if we should rather take "rpm -ql kernel | grep initramfs" .

This will prevent that our logic changes when the format of the initramfs filename changes.
Line 7:     $LIVE_ROOT/isolinux/initrd0.img
Line 8: 
Line 9: if [ -f "ovirt-authorized_keys" ]; then
Line 10:   echo "Adding authorized_keys to Image"


-- 
To view, visit http://gerrit.ovirt.org/36987
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id676ce0fb22ec7f8155b6814750820659a7ead6f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes