[node-patches] Change in ovirt-node-iso[master]: Fixing gluster repositories to include both arch and non arch

[dougsland at redhat.com]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Fixing gluster repositories to include both arch and non arch
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

-1 as I have comments.

http://gerrit.ovirt.org/#/c/37114/1/Makefile.am
File Makefile.am:

Line 94:         UPDATES_REPO_LINE="repo --name=centos-updates --mirrorlist=$(CENTOS_MIRROR)?release=$(CENTOS)&arch=${ARCH}&repo=updates \n" ;\
Line 95:         EPEL_REPO_LINE="repo --name=epel --baseurl=http://dl.fedoraproject.org/pub/epel/$(CENTOS)/${ARCH} \n" ;\
Line 96:         OVIRT_REPO_LINE="repo --name=ovirt-repo --baseurl=$(OVIRT_BASE_URL)/el$(CENTOS)\n" ;\
Line 97: 		GLUSTER_REPO_LINE="repo --name=ovirt-$(OVIRT_VERSION)-glusterfs-noarch-epel --baseurl=http://download.gluster.org/pub/gluster/glusterfs/LATEST/EPEL.repo/epel-$(CENTOS)/noarch\n" ;\
Line 98: 		GLUSTER_REPO_LINE="repo --name=ovirt-$(OVIRT_VERSION)-glusterfs-${ARCH}-epel --baseurl=http://download.gluster.org/pub/gluster/glusterfs/LATEST/EPEL.repo/epel-$(CENTOS)/${ARCH}\n" ;\
#1 - Please do not mix tabs and spaces, UPDATES_REPO_LINE, EPEL_REPO_LINE and others do not use tab.
#2 - I see you are re-defining GLUSTER_REPO_LINE is that correct? Maybe add a different var for noarch repos and x86_64 repos and add it to the below printf ?
Line 99:         printf "$${CENTOS_REPO_LINE}" > repos.ks ;\
Line 100:         printf "$${UPDATES_REPO_LINE}" >> repos.ks ;\
Line 101:         printf "$${EPEL_REPO_LINE}" >> repos.ks ;\
Line 102:         printf "$${OVIRT_REPO_LINE}" >> repos.ks ;\


-- 
To view, visit http://gerrit.ovirt.org/37114
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib794498d0bd5b70b8aab95d9d539708ff8894ac7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node-iso
Gerrit-Branch: master
Gerrit-Owner: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes