[node-patches] Change in ovirt-node-iso[master]: Makefile.am: Make env var OVIRT_REPO_URL work again

fabiand at redhat.com fabiand at redhat.com
Wed Jan 21 13:32:52 UTC 2015


Fabian Deutsch has posted comments on this change.

Change subject: Makefile.am: Make env var OVIRT_REPO_URL work again
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/37143/1/Makefile.am
File Makefile.am:

Line 107:             UPDATE_REPO_LINE="repo --name=$${FEDORA_REPO}-updates --mirrorlist=$(FEDORA_MIRROR)?repo=updates-released-f$(FEDORA)&arch=$(ARCH)\n" ;\
Line 108:             printf "$${EDORA_REPO_LOC}" >> repos.ks ;\
Line 109:             printf "$${UPDATE_REPO_LINE}" >> repos.ks ;\
Line 110:             printf "$${VIRT_PREVIEW_LINE}" >> repos.ks ;\
Line 111:       else \
I think we can even pull it out of the if.

Because we always want to append OVIRT_REPO_URL if it's present independent of the distro.
Line 112:             echo "# OVIRT_REPO_URL=$(OVIRT_REPO_URL)" > $@ ;\
Line 113:             for repo in $(OVIRT_REPO_URL); do \
Line 114:                echo "repo --name=repo$${i} --baseurl=$${repo}" >> $@ ;\
Line 115:                i=$${i}_ ;\


-- 
To view, visit http://gerrit.ovirt.org/37143
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id58ec2464149224ad38270af7a5435f16e02b9ff
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node-iso
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes



More information about the node-patches mailing list