[node-patches] Change in ovirt-node[master]: Don't hide bridges in the network page

rbarry at redhat.com rbarry at redhat.com
Wed Jan 21 19:48:51 UTC 2015


Ryan Barry has uploaded a new change for review.

Change subject: Don't hide bridges in the network page
......................................................................

Don't hide bridges in the network page

Show bridges instead of hiding them. They appear as managed, so
there's little risk of users unconfiguring them (bridge interfaces
should not exist without registration in the first place).

Change-Id: I1b543c3be4778482b777635dabe6962823ce40b8
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1097668
Signed-off-by: Ryan Barry <rbarry at redhat.com>
---
M src/ovirt/node/utils/network.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/03/37203/1

diff --git a/src/ovirt/node/utils/network.py b/src/ovirt/node/utils/network.py
old mode 100644
new mode 100755
index 3fc7811..5a9c102
--- a/src/ovirt/node/utils/network.py
+++ b/src/ovirt/node/utils/network.py
@@ -611,7 +611,7 @@
         nics = [NIC(ifname) for ifname
                 in self.relevant_ifnames(filter_vlans=True,
                                          filter_bonds=False,
-                                         filter_bridges=True)]
+                                         filter_bridges=False)]
 
         bridges = [nic for nic in nics if nic.typ == "bridge"]
         vlans = [nic for nic in nics if nic.typ == "vlan"]
@@ -623,7 +623,7 @@
 
         candidates = {}
 
-        for nic in nics + vlans:
+        for nic in nics + vlans + bridges:
             candidate = self.build_nic_model(nic.ifname, filter_slaveless,
                                              filter_configured)
             if candidate:


-- 
To view, visit http://gerrit.ovirt.org/37203
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b543c3be4778482b777635dabe6962823ce40b8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>



More information about the node-patches mailing list