[node-patches] Change in ovirt-node[master]: Making the install device selection page use only disk devices.

fabiand at redhat.com fabiand at redhat.com
Thu Jan 22 09:11:14 UTC 2015


Fabian Deutsch has posted comments on this change.

Change subject: Making the install device selection page use only disk devices.
......................................................................


Patch Set 4: Code-Review-1

I am not sure if the logic will work. The reason for this is that lsblk will list a device twice (at least plain lsblk does  it).
Once the raw device (sd*) and the second time the mpath device on top of it.
In the current logic, both devices will be shown in the TUI.

Can you please confirm that a (by mpath) claimed raw device and the mpath device on top are not both listed, but only the mpath device?

-- 
To view, visit http://gerrit.ovirt.org/37043
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1e398ff28b984093163c13c13af125eb7428bec
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No



More information about the node-patches mailing list