[node-patches] Change in ovirt-node[master]: ovirt-auto-install: fix imports

dougsland at redhat.com dougsland at redhat.com
Mon Jul 6 22:29:25 UTC 2015


Douglas Schilling Landgraf has posted comments on this change.

Change subject: ovirt-auto-install: fix imports
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/43175/4/scripts/ovirt-auto-install.py
File scripts/ovirt-auto-install.py:

Line 223:         hooks.Hooks.post_auto_install()
Line 224: 
Line 225: def is_iscsi_install():
Line 226:     if OVIRT_VARS.has_key("OVIRT_ISCSI_INSTALL") and \
Line 227:             OVIRT_VARS["OVIRT_ISCSI_INSTALL"].upper() == "Y":
> Is this tested?
As we talked over irc OVIRT_VARS is declared in the top of source and it's tested.
Line 228:         return True
Line 229: 
Line 230: def is_stateless():
Line 231:     # check if theres a key first


-- 
To view, visit https://gerrit.ovirt.org/43175
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbe43cc316540752ed9710fb2eca96f4c2cf8670
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes



More information about the node-patches mailing list