[node-patches] Change in ovirt-node[master]: confirmation_page: Do not compare strings and numbers

fabiand at redhat.com fabiand at redhat.com
Wed Jul 15 15:17:41 UTC 2015


Fabian Deutsch has submitted this change and it was merged.

Change subject: confirmation_page: Do not compare strings and numbers
......................................................................


confirmation_page: Do not compare strings and numbers

In commit ab550a39 we added the validation for a warning
message but the string "MB" is available in one of
variables making the comparation impossible (numbers vs string).
The patch 45c479bf added "MB" string in the data_size
model making ab550a39 commit not able to finish.
This patch avoid such exception:
ValueError: invalid literal for int() with base 10

Change-Id: I700a4aed2f7c11cb5081377d65bc622e0a5e1f32
Signed-off-by: Douglas Schilling Landgraf <dougsland at redhat.com>
---
M src/ovirt/node/installer/core/confirmation_page.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Fabian Deutsch: Looks good to me, approved; Passed CI tests
  Douglas Schilling Landgraf: Verified



-- 
To view, visit https://gerrit.ovirt.org/43174
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I700a4aed2f7c11cb5081377d65bc622e0a5e1f32
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the node-patches mailing list