[node-patches] Change in ovirt-node[master]: init: Restart networking early during boot

[dougsland at redhat.com]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: init: Restart networking early during boot
......................................................................


Patch Set 2:

(1 comment)

First, the patch seems good to make the report disapper. However, What about create a systemd unit ovirt-node-mountbind and use Before=vdsm, supervdsm  and restart the needed service for mountbind issue like network and audit service? We could start it in the same place currently we restart these services but with systemd guarantee it will be before vdsm and supervdsm?

https://gerrit.ovirt.org/#/c/43781/2/scripts/ovirt-init-functions.sh.in
File scripts/ovirt-init-functions.sh.in:

Line 918: 
Line 919:         # A few services need to be restarted to pickup the newly bind-mounted
Line 920:         # config files (mounted in by the preceeding mount_config call)
Line 921:         mount -a
Line 922:         swapon -a
Missed.
# Small hack to fix https://bugzilla.redhat.com/show_bug.cgi?id=805313
Line 923:         service network restart
Line 924:         service auditd restart
Line 925:     fi
Line 926:     log "Updating $OVIRT_DEFAULTS"


-- 
To view, visit https://gerrit.ovirt.org/43781
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I040f69d6df0a24a31f8057121029d04c172646da
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes