[node-patches] Change in ovirt-node[master]: persisting the ssh fingerprint keys

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: persisting the ssh fingerprint keys
......................................................................


Patch Set 1:

(1 comment)

What about the other appearances?

src/ovirtnode/ovirtfunctions.py:1199:    for f in ["/etc/ssh/ssh_host%s_key" % t for t in ["", "_dsa", "_rsa"]]:

hooks/on-boot/03-validate-owner-ssh-keys

They might be not directly affected, but can suffer from the same cause (that bnew files are there, which we now also need to handle in those new places).

https://gerrit.ovirt.org/#/c/44184/1/scripts/ovirt-init-functions.sh.in
File scripts/ovirt-init-functions.sh.in:

Line 1523:                 runcon -t unconfined_t "$handler" 2>&1
Line 1524:             done
Line 1525:         fi
Line 1526: 
Line 1527:         ovirt_store_config $(ls /etc/ssh_host*_key*)
Any specific reason why you moved this to this line?
Line 1528: 
Line 1529:         # FIXME is this still needed?
Line 1530:         if is_standalone; then
Line 1531:             return 0


-- 
To view, visit https://gerrit.ovirt.org/44184
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b7e2b1a775f2c59fc7b40a8078a3c6eadf84855
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes