[node-patches] Change in ovirt-node[master]: Always restart the kdump service, even if kdumpctl is present

[rbarry at redhat.com]

Ryan Barry has uploaded a new change for review.

Change subject: Always restart the kdump service, even if kdumpctl is present
......................................................................

Always restart the kdump service, even if kdumpctl is present

Restart kdump no matter what, so the output of "systemctl status
kdump.service" or "service kdump status" matches what kdumpctl
already knows, and the output is captured in the journal.

Leave "kdumpctl restart" anyway, since "service kdump restart"
does not pass failures back, and we want to catch the exception
so we know, even if this means duplicating a little work.

Change-Id: I187a9b3642dc1ee4b353b3adfdb051c58545fe01
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1180371
Signed-off-by: Ryan Barry <rbarry at redhat.com>
---
M src/ovirt/node/config/defaults.py
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/10/41910/1

diff --git a/src/ovirt/node/config/defaults.py b/src/ovirt/node/config/defaults.py
index c393b94..f7776ae 100755
--- a/src/ovirt/node/config/defaults.py
+++ b/src/ovirt/node/config/defaults.py
@@ -1280,8 +1280,7 @@
                             utils.process.check_call(["kdumpctl", "restart"],
                                                      stdout=DEVNULL,
                                                      stderr=DEVNULL)
-                    else:
-                        system.service("kdump", "restart")
+                    system.service("kdump", "restart")
                 except utils.process.CalledProcessError as e:
                     self.logger.info("Failure while restarting kdump: %s" % e)
                     unmount_config("/etc/kdump.conf")


-- 
To view, visit https://gerrit.ovirt.org/41910
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I187a9b3642dc1ee4b353b3adfdb051c58545fe01
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>