[node-patches] Change in ovirt-node[master]: Use a better URL validator. RegexValidator adds flags

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: Use a better URL validator. RegexValidator adds flags
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Basically I'd liek to keep the simplicity of the URL validator.

I'm favoring an approach where we handle this special colon case in the url validator, then we do not need to a) change the __init__ signature b) don't need to add the complex regexp (which is much harder to fix if we find an error in there).

https://gerrit.ovirt.org/#/c/42394/2/src/ovirt/node/valid.py
File src/ovirt/node/valid.py:

Line 579
Line 580
Line 581
Line 582
Line 583
What about just adding here the special handling of the collon-in-netloc case?

That is fine for me, because I don't yet see any other lack of the urllib validator


-- 
To view, visit https://gerrit.ovirt.org/42394
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13429d0cc600446c8fd4c1be5e5a8752d6d992f7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes