[node-patches] Change in ovirt-node[master]: Use a better URL validator. RegexValidator adds flags

[fabiand at redhat.com]

Fabian Deutsch has submitted this change and it was merged.

Change subject: Use a better URL validator. RegexValidator adds flags
......................................................................


Use a better URL validator. RegexValidator adds flags

valid.url relied on urlparse very heavily, but urlparse did not
throw an exception on some invalid addresses. urllib3 does this
better, but is not available in EL6.

Use the URL validator from django instead, and validate with a
regex.

To support this, give RegexValidator easier-to-set flags as part
of the class constructor.

Change-Id: I13429d0cc600446c8fd4c1be5e5a8752d6d992f7
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1231029
Signed-off-by: Ryan Barry <rbarry at redhat.com>
---
M src/ovirt/node/valid.py
1 file changed, 139 insertions(+), 30 deletions(-)

Approvals:
  Fabian Deutsch: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/42394
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I13429d0cc600446c8fd4c1be5e5a8752d6d992f7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org