[node-patches] Change in ovirt-node[master]: Validate the calculated size when fill is checked and unchecked

[rbarry at redhat.com]

Ryan Barry has uploaded a new change for review.

Change subject: Validate the calculated size when fill is checked and unchecked
......................................................................

Validate the calculated size when fill is checked and unchecked

This prevents us from getting into a situation where unchecking
and rechecking the "fill" button erroneously enables the
"Continue" button.

Change-Id: If7b0cf0b9208df16d0c0f9c8f711e98e8bd73c97
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1177308
Signed-off-by: Ryan Barry <rbarry at redhat.com>
---
M src/ovirt/node/installer/core/storage_vol_page.py
1 file changed, 7 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/97/42897/1

diff --git a/src/ovirt/node/installer/core/storage_vol_page.py b/src/ovirt/node/installer/core/storage_vol_page.py
index 5860950..85abd0b 100644
--- a/src/ovirt/node/installer/core/storage_vol_page.py
+++ b/src/ovirt/node/installer/core/storage_vol_page.py
@@ -118,10 +118,6 @@
     def on_change(self, changes):
         self._model.update(changes)
 
-        if "storage.fill_data" in changes:
-            if self._fill is not changes["storage.fill_data"]:
-                self._fill = changes["storage.fill_data"]
-                self.application.show(self.ui_content())
         size_keys = ["storage.efi_size", "storage.root_size",
                      "storage.swap_size", "storage.config_size",
                      "storage.logging_size"]
@@ -147,6 +143,13 @@
                         self.widgets[w].notice("")
                 self._on_ui_change(self._NodePlugin__invalid_changes)
 
+        if "storage.fill_data" in changes:
+            self._on_ui_change(plugins.Changeset(
+                {"storage.data_size": self._model["storage.data_size"]}))
+            if self._fill is not changes["storage.fill_data"]:
+                self._fill = changes["storage.fill_data"]
+                self.application.show(self.ui_content())
+
     def on_merge(self, effective_changes):
         changes = self.pending_changes(False)
         if changes.contains_any(["button.back"]):


-- 
To view, visit https://gerrit.ovirt.org/42897
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If7b0cf0b9208df16d0c0f9c8f711e98e8bd73c97
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>