[node-patches] Change in ovirt-node[master]: Unpersist and repersist snmpd.conf so it can be moved

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: Unpersist and repersist snmpd.conf so it can be moved
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/42771/1/src/ovirt/node/setup/snmp/snmp_model.py
File src/ovirt/node/setup/snmp/snmp_model.py:

Line 47:     cmd = "cat %s | grep createUser | grep -v '^#' | awk '{print $4}'" % conf
Line 48:     oldpwd = process.pipe(cmd, shell=True).strip()
Line 49: 
Line 50:     if len(oldpwd) > 0:
Line 51:         change_password(oldpwd)
In this branch, snmpd will not be started again. change_password() is stopping it at the end.
Line 52:     else:
Line 53:         system.service("snmpd", "stop")
Line 54:         # net-snmp tries to move this to a backup. We don't care about that,
Line 55:         # but it fails, and fails to create the user if it's persisted (and


-- 
To view, visit https://gerrit.ovirt.org/42771
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ff002717a8bf2744efa995f2e7e09a60b1eaede
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes