[node-patches] Change in ovirt-node[master]: Add configure_* methods to ovirt.node.config.defaults

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: Add configure_* methods to ovirt.node.config.defaults
......................................................................


Patch Set 1:

(7 comments)

Looks nice, a few comments tho

https://gerrit.ovirt.org/#/c/38220/1/src/ovirt/node/config/defaults.py
File src/ovirt/node/config/defaults.py:

Line 1384: configure_dh_alua
This is somewhat redudant, to include dh_alua in the name, if dh alua is in the class name.
I am more in favor of something like: configure(enabled)


Line 1429: configure_netconsole
Same as above, redundant to have netconsole in the method name, if it's included in the class name. What about just configure(…)

And should it include port=None (using the default port)


Line 1503: configure_logrotate_interval
Same reasoning as above, drop the logrotate part in the method name


Line 1506: configure_logrotate_max_size
As above


Line 1557: configure_layout
Same as far above (drop the redundant name)


Line 1598: configure_domain
Same as above


Line 1662: configure_bytes
let's include aesni_bytes, to make clear that it is about the aes bytes used for aes NI - iirc ..


Consider to merge this into the configure_asesni method, if the bytes are specific to aesni


-- 
To view, visit https://gerrit.ovirt.org/38220
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbd9543d0ec97ba724b9a6cf675036944bc4c24a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes