[node-patches] Change in ovirt-node[master]: Add configuremethods to ovirt.node.config.defaults

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: Add configuremethods to ovirt.node.config.defaults
......................................................................


Patch Set 4:

(5 comments)

I missed some stuff in the initial review, sorry about that.

Some more comments now, but that should be it.

We can do a second round to make the configure_* signatures suitable for dbus, esüpecially removing defaults

    def configure(foo=1):

can become

    def configure(foo):
        foo = foo or 1

https://gerrit.ovirt.org/#/c/38220/4/src/ovirt/node/config/defaults.py
File src/ovirt/node/config/defaults.py:

Line 801: configure_nameservers
Not sure why I missed it in the first review, but the same reasoning: nameservers is redundant in the method signature, because the class is called that way.


Line 903: configure_timeservers
Same as above


Line 975: configure_syslog
As above


Line 1016: configure_collectd
as above


Line 1666: configure_aesni_bytes
Should this be pulled into the configure_aesni?


-- 
To view, visit https://gerrit.ovirt.org/38220
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbd9543d0ec97ba724b9a6cf675036944bc4c24a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes