[node-patches] Change in ovirt-node[master]: Add configuremethods to ovirt.node.config.defaults

[rbarry at redhat.com]

Ryan Barry has posted comments on this change.

Change subject: Add configuremethods to ovirt.node.config.defaults
......................................................................


Patch Set 5:

I'm not sure about the AES bytes. If I can find what reasonable defaults are for either of these settings, I'll update it.

Regarding the "configure(foo=1)..." change, that's going to touch a lot more than just config.defaults.

Using Network.configure_no_networking as an example, it's called both with and without parameters. We're going to have problems calling methods with too few or too many parameters. One of the only times I can think of where I wish Python had the same overloading semantics as some other languages.

We can step through the codebase and correct these, though it may not help dbus itself.

Happy to discuss options beyond this patch, though

-- 
To view, visit https://gerrit.ovirt.org/38220
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbd9543d0ec97ba724b9a6cf675036944bc4c24a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No