[node-patches] Change in ovirt-node[master]: scripts: mimic output of previous un/persist cmds

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: scripts: mimic output of previous un/persist cmds
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/38394/2/scripts/unpersist
File scripts/unpersist:

Line 39: exists
Please use `conf.exists(path)` instead


Line 43: os
as above


https://gerrit.ovirt.org/#/c/38394/2/src/ovirt/node/utils/fs/__init__.py
File src/ovirt/node/utils/fs/__init__.py:

Line 432: False
I am not sure we can change the return code like this.

We need to make sure that all consumers of this method do _not_ rely on the returncode.


-- 
To view, visit https://gerrit.ovirt.org/38394
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f52960d7da50c35ada14474c2a46a38b5e153de
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes