[node-patches] Change in ovirt-node[master]: Don't add callbacks to the queue if they're None

fabiand at redhat.com fabiand at redhat.com
Fri Mar 13 10:00:51 UTC 2015


Fabian Deutsch has posted comments on this change.

Change subject: Don't add callbacks to the queue if they're None
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/35607/1/src/ovirt/node/ui/urwid_builder.py
File src/ovirt/node/ui/urwid_builder.py:

Line 465: callback
To prevent indentation, please change the logic to:

    if not callback:
        self.logger.debug("Won't call a None callback")
        return

    ....


-- 
To view, visit https://gerrit.ovirt.org/35607
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1635275fab0c087114872c558446b790e4b2fe6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes



More information about the node-patches mailing list