[node-patches] Change in ovirt-node[master]: valid: add to FQDNOrIPAddress, HostnameLength validation

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: valid: add to FQDNOrIPAddress, HostnameLength validation
......................................................................


Patch Set 5:

(1 comment)

Just one nitpick - testing!

https://gerrit.ovirt.org/#/c/38950/5/src/ovirt/node/valid.py
File src/ovirt/node/valid.py:

Line 448:     True
Line 449:     >>> FQDNOrIPAddress()("::1")
Line 450:     True
Line 451:     >>> FQDNOrIPAddress().validate("")
Line 452:     False
Please extend the doctests to also cover this new "feature"
Line 453:     """
Line 454: 
Line 455:     def __init__(self, allow_ipv6=True):
Line 456:         self._validator = FQDN() | IPAddress(allow_ipv6) & HostnameLength()


-- 
To view, visit https://gerrit.ovirt.org/38950
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02d907b69a15506ffc9337f642d97a301bf3c9f0
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes