[node-patches] Change in ovirt-node[ovirt-3.5]: logger: replace .debug statement for .warning

fabiand at redhat.com fabiand at redhat.com
Fri Mar 27 11:14:57 UTC 2015


Hello Douglas Schilling Landgraf,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/39266

to review the following change.

Change subject: logger: replace .debug statement for .warning
......................................................................

logger: replace .debug statement for .warning

If there is no default label on restorecon call, we
should log as warning.

Change-Id: I32ef4be12f9c7147a8d0b05d5fceb20648d54adc
Signed-off-by: Douglas Schilling Landgraf <dougsland at redhat.com>
---
M src/ovirt/node/utils/security.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/66/39266/1

diff --git a/src/ovirt/node/utils/security.py b/src/ovirt/node/utils/security.py
index d979d30..007cabc 100644
--- a/src/ovirt/node/utils/security.py
+++ b/src/ovirt/node/utils/security.py
@@ -104,7 +104,7 @@
         try:
             selinux.restorecon(abspath)
         except OSError:
-            self._logger.debug('No default label: "%s"', abspath)
+            self._logger.warning('No default label: "%s"', abspath)
 
     def getcon(self, abspath):
         """ Return context of file, symlink or dir """


-- 
To view, visit https://gerrit.ovirt.org/39266
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I32ef4be12f9c7147a8d0b05d5fceb20648d54adc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>



More information about the node-patches mailing list