[node-patches] Change in ovirt-node[master]: Add netmask validators for ipv4 and ipv6

fabiand at redhat.com fabiand at redhat.com
Fri May 8 10:14:58 UTC 2015


Fabian Deutsch has submitted this change and it was merged.

Change subject: Add netmask validators for ipv4 and ipv6
......................................................................


Add netmask validators for ipv4 and ipv6

Add an ipv4 validator with the right text. We could go full-bore
and add a CIDR validator pretty easily as well, but then it'd be
a large change with modifications to config.defaults.Network and
ovirt.node.config.network, which isn't worth it at the moment,
since we can just explicitly tell users to use dot.decimal format

Add an ipv6 validator which does use CIDR, matching the current
page behavior (and decimal makss aren't valid for ipv6 anyway)

Change-Id: I25856f1a6df4c926063b8b5efc2807e73771d416
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1155508
Signed-off-by: Ryan Barry <rbarry at redhat.com>
---
M src/ovirt/node/setup/core/network_page.py
M src/ovirt/node/valid.py
2 files changed, 37 insertions(+), 3 deletions(-)

Approvals:
  Fabian Deutsch: Looks good to me, approved
  Ryan Barry: Verified



-- 
To view, visit https://gerrit.ovirt.org/40637
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I25856f1a6df4c926063b8b5efc2807e73771d416
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the node-patches mailing list