[node-patches] Change in ovirt-node[master]: Trigger udevadm in the installer to refresh disk info

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: Trigger udevadm in the installer to refresh disk info
......................................................................


Patch Set 1: Code-Review+1 Verified-1

(1 comment)

Just oen nitpick, otherwise good.

https://gerrit.ovirt.org/#/c/40827/1/src/ovirt/node/utils/storage.py
File src/ovirt/node/utils/storage.py:

Line 105: settle
Please add the `--timeout=10` option

That should be an reasonable timout, as we do not want to block forever (in the worst case)


-- 
To view, visit https://gerrit.ovirt.org/40827
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0446e0dfd093528d2a95bfd857c29e2a89f25b41
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes