[node-patches] Change in ovirt-node[master]: Trigger udevadm in the installer to refresh disk info

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: Trigger udevadm in the installer to refresh disk info
......................................................................


Patch Set 3: -Code-Review

(1 comment)

https://gerrit.ovirt.org/#/c/40827/3/src/ovirt/node/utils/storage.py
File src/ovirt/node/utils/storage.py:

Line 101:                 self._fake_devices[args[1]] = Device(*tuple(args))
Line 102:         else:
Line 103:             if refresh:
Line 104:                 try:
Line 105:                     process.check_call(["udevadm", "settle", "--timeout=10"])
Shouldn't we call the settle after we called the trigger?

That might make more sense.
I didn't catch this the ifrst time I looked.
Line 106:                     process.check_call(["udevadm", "trigger",
Line 107:                                         "--action=change",
Line 108:                                         "--subsystem-match=block"])
Line 109:                 except process.CalledProcessError:


-- 
To view, visit https://gerrit.ovirt.org/40827
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0446e0dfd093528d2a95bfd857c29e2a89f25b41
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes