[node-patches] Change in ovirt-node[master]: Be more clever removing basic video options

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: Be more clever removing basic video options
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/36746/6/recipe/common-nochroot.ks
File recipe/common-nochroot.ks:

Line 22: sed -i -e '/label check0/{N;N;N;d;}' $LIVE_ROOT/isolinux/isolinux.cfg
Line 23: 
Line 24: # Rename Boot option to Install or Upgrade
Line 25: sed -i 's/^  menu label Boot$/  menu label Install or Upgrade/' $LIVE_ROOT/isolinux/isolinux.cfg
Line 26: grep -A2 -B1 -E "^  menu label Boot \(Basic Video\)" /tmp/isolinux.cfg  | \
I think we can use 'menu hide' instead of using this approach.
Using menu hide is less invasive.

http://www.syslinux.org/wiki/index.php/Menu#MENU_HIDE
Line 27:     diff - /tmp/isolinux.cfg  | sed '/^[^>]/d;s/^> //;' > $LIVE_ROOT/isolinux/isolinux.cfg.tmp
Line 28: mv $LIVE_ROOT/isolinux/isolinux.cfg.tmp $LIVE_ROOT/isolinux/isolinux.cfg
Line 29: 
Line 30: 


-- 
To view, visit https://gerrit.ovirt.org/36746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia84bc10f3d44add137e51a8445cd7b6842183243
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes