[node-patches] Change in ovirt-node[ovirt-3.5]: passwd: Refectoring password schema

[rbarry at redhat.com]

Ryan Barry has posted comments on this change.

Change subject: passwd: Refectoring password schema
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/48166/2/src/ovirt/node/installer/core/progress_page.py
File src/ovirt/node/installer/core/progress_page.py:

Line 19: # MA  02110-1301, USA.  A copy of the GNU General Public License is
Line 20: # also available at http://www.gnu.org/copyleft/gpl.html.
Line 21: from ovirt.node import plugins, ui, utils
Line 22: from ovirt.node.config import defaults
Line 23: from ovirt.node.utils import console, system, security
Why import security at the top level instead of just Passwd?
Line 24: import threading
Line 25: 
Line 26: 
Line 27: """


https://gerrit.ovirt.org/#/c/48166/2/src/ovirt/node/utils/security.py
File src/ovirt/node/utils/security.py:

Line 116:         passwd = self.cryptPassword(password)
Line 117:         try:
Line 118:             Config().unpersist("/etc/passwd")
Line 119:             Config().unpersist("/etc/shadow")
Line 120:             t = threading.Thread(target=admin.setpassUser, args=(root, passwd, "is_crypted"))
We can probably drop the threading here
Line 121:             t.start()
Line 122:             while t.is_alive():
Line 123:                 t.join()
Line 124:         except:


-- 
To view, visit https://gerrit.ovirt.org/48166
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If78688f983c60a2cf499c6a6a9dcf2e12a1db5dc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes