[node-patches] Change in ovirt-node[master]: password: Replace libuser and update the persist/unpersist c...

[dougsland at redhat.com]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: password: Replace libuser and update the persist/unpersist calls
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/48216/3/src/ovirtnode/password.py
File src/ovirtnode/password.py:

Line 44:         Config().unpersist("/etc/passwd")
Line 45: 
Line 46:         # Workaround for admin.setpassUser (libuser) not working properly
Line 47:         # with persist command during upgrades/reinstall or downgrade
Line 48:         # See more: BZ#1263648
> In further testing, libuser is not the problem.
Hi Ryan,

I agree the libuser is not the problem, however It's clear libuser has been affected by our installer which has locked files used by libuser.
This is the workaround for the issue.
Line 49:         #
Line 50:         with open("/etc/shadow", "r") as f:
Line 51:             shadow_file = f.readlines()
Line 52: 


-- 
To view, visit https://gerrit.ovirt.org/48216
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8a1b3fe1343e6820e83e2a9db8ff6715d959336
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes