[node-patches] Change in ovirt-node[master]: network: set hostname must unpersist/persist

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: network: set hostname must unpersist/persist
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/48392/1/src/ovirt/node/config/defaults.py
File src/ovirt/node/config/defaults.py:

Line 739
Line 740
Line 741
Line 742
Line 743
The perists/unpersist needs to be kept in the defaults moduel. The other modules in .utils and .config should rather not be aware of it


https://gerrit.ovirt.org/#/c/48392/1/src/ovirt/node/config/network.py
File src/ovirt/node/config/network.py:

Line 225: def hostname(new_hostname=None):
Line 226:     """Get or set the current hostname
Line 227:     """
Line 228:     if new_hostname:
Line 229:         fs.Config().unpersist("/etc/hostname")
This module (ovirt.node.config.network) should not contain persist calls, all of this should go to ovirt-node.config.defaults
Line 230:         # hostnamectl set's runtime and config file
Line 231:         utils.process.check_call(["hostnamectl", "set-hostname",
Line 232:                                   new_hostname])
Line 233: 


-- 
To view, visit https://gerrit.ovirt.org/48392
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf37e97d3450ac60bfc1e2ee302b6ab728006973
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes