[node-patches] Change in ovirt-node[master]: Add console.size, and shorten the password message on a smal...

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: Add console.size, and shorten the password message on a small term
......................................................................


Patch Set 5: Continuous-Integration+1

(1 comment)

https://gerrit.ovirt.org/#/c/45457/5/src/ovirt/node/utils/security.py
File src/ovirt/node/utils/security.py:

Line 86:         except ValueError as e:
Line 87:             console_size = console.size() if console.isatty() else None
Line 88:             message = "You have provided a weak password!"
Line 89: 
Line 90:             if console_size and console_size.rows > 24:
Nice to use a namedTuple here
Line 91:                 message += "Strong passwords contain a mix of uppercase, "
Line 92:                 message += "lowercase, numeric and punctuation characters. "
Line 93:                 message += "They are six or more characters long and "
Line 94:                 message += "do not contain dictionary words. "


-- 
To view, visit https://gerrit.ovirt.org/45457
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa580235f545e41dd25236b5dca2e6310b68ccca
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes