[node-patches] Change in ovirt-node[master]: Persist all of /var/lib/net-snmp instead of just snmpd.conf

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: Persist all of /var/lib/net-snmp instead of just snmpd.conf
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/46533/5/src/ovirt/node/setup/snmp/snmp_model.py
File src/ovirt/node/setup/snmp/snmp_model.py:

Line 55:         process.check_call(["net-snmp-create-v3-user", "-A", password, "-a",
Line 56:                             "SHA", "-x", "AES", "root"])
Line 57:         system.service("snmpd", "start")
Line 58: 
Line 59:         fs.Config().persist("/etc/snmp/snmpd.conf")
Shouldn't this persist the snmp_conf?
Line 60: 
Line 61:     firewall.open_port(port="161", proto="udp")
Line 62: 
Line 63: 


-- 
To view, visit https://gerrit.ovirt.org/46533
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifef49615cca8eae9107d3ea409db30f71c2815ae
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes